Chandni Singh commented on YARN-5015:

 [~leftnoteasy] Please find my answers below to some of the questions:
{quote}2) mv org.apache.hadoop.yarn.server.retry.SlidingWindowRetryPolicy to 
org.apache.hadoop.yarn.server.nodemanager.containermanager.container: Why it is 
in server-common?
It is in server common so that later we can use it for AM restart. Eventually 
we have to unify the code for AM and container restart, so this class needs to 
be accessible to RM as well.
{quote}4) calculatePendingRetries

return retryContext.getRemainingRetries() == -1 ? retryContext.getMaxRetries() 
: retryContext.getRemainingRetries();

 Why check {{retryContext.getRemainingRetries() == -1}}? Should this be 
getMaxRetries() == -1?
The default value of {{remainingRetries}} is -1, that is, when it is not set, 
it is -1.

If remainingRetries is not set then pending retries = {{maxRetries}}. 
Otherwise, pendingRetries = {{remainingRetries}}.
 Just after this we update the {{remainingRetries}} = {{pendingRetries}} - 1.

> Support sliding window retry capability for container restart 
> --------------------------------------------------------------
>                 Key: YARN-5015
>                 URL: https://issues.apache.org/jira/browse/YARN-5015
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Chandni Singh
>            Priority: Major
>              Labels: oct16-medium
>         Attachments: YARN-5015.01.patch, YARN-5015.02.patch, 
> YARN-5015.03.patch
> We support sliding window retry policy for AM restarts (Introduced in 
> YARN-611). Similar sliding window retry policy is needed for container 
> restarts.
> With this change, we can introduce a common class for 
> SlidingWindowRetryPolicy ( suggested by [~vvasudev] in the comments) and 
> integrate it to container restart. 
> In a subsequent jira, we can modify the AM code to use 
> SlidingWindowRetryPolicy which will unify the AM and container restart code.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to