Wangda Tan commented on YARN-5015:

[~csingh], could you explain a bit about how this logic will be shared by RM 
and AM? Per my understanding, restart AM container should be handled by NM, 
correct? Did you mean AM needs to implement similar logic to restart its 
container? If so, why not directly leverage NM logics to handle container auto 

bq. The default value of remainingRetries is -1, that is, when it is not set, 
it is -1.
How about set initial remainingRetries directly to maxRetries? Which can avoid 
such check

> Support sliding window retry capability for container restart 
> --------------------------------------------------------------
>                 Key: YARN-5015
>                 URL: https://issues.apache.org/jira/browse/YARN-5015
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Chandni Singh
>            Priority: Major
>              Labels: oct16-medium
>         Attachments: YARN-5015.01.patch, YARN-5015.02.patch, 
> YARN-5015.03.patch
> We support sliding window retry policy for AM restarts (Introduced in 
> YARN-611). Similar sliding window retry policy is needed for container 
> restarts.
> With this change, we can introduce a common class for 
> SlidingWindowRetryPolicy ( suggested by [~vvasudev] in the comments) and 
> integrate it to container restart. 
> In a subsequent jira, we can modify the AM code to use 
> SlidingWindowRetryPolicy which will unify the AM and container restart code.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to