Rohith Sharma K S commented on YARN-7581:

Overall patch approach looks good. Some comments

l.no 211, 
- method extractColumnFamiliesFromFiltersBasedOnFilters has duplicated code for 
else if conditions. 
- Can this  _new String(cf, Charset.forName("UTF-8")_ be extracted to utils so 
that we don't miss syntax anytime.

In all the *EntityReader implementations, by default cfsInFields added for INFO 
family. Does it because of assumption that info field will be retrieved by 
default all the time? 

> HBase filters are not constructed correctly in ATSv2
> ----------------------------------------------------
>                 Key: YARN-7581
>                 URL: https://issues.apache.org/jira/browse/YARN-7581
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: ATSv2
>    Affects Versions: 3.0.0-beta1
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-7581.00.patch, YARN-7581.01.patch, 
> YARN-7581.02.patch
> Post YARN-7346,
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters() and 
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters() 
> start to fail when hbase.profile is set to 2.0)
> *Error Message*
>  [ERROR] Failures:
>  [ERROR] 
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters:1266 
> expected:<2> but was:<0>
>  [ERROR] 
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters:1523 
> expected:<1> but was:<0>

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to