[
https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402510#comment-16402510
]
Vrushali C commented on YARN-7581:
----------------------------------
Thanks for the patch [~haibochen] ! I have some questions.
I am trying to think about the UTF8 encoding for strings. Any reason we are
explicitly defining convertBytesToString and convertStringToBytes instead of
using the ones that HBase provides? The Bytes.toString conversions assume UTF8
enconding
https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/util/Bytes.html#toString-byte:A-
Second question is about always including the info field. Say, for example,
someone wanted to see their megabytemillis counter value, do we need to
retrieve the info field in that case?
In general, adding the fields in the CFs to make the filter conditions work
correct seems fine to me. +1 on overall patch apart from the above questions.
> HBase filters are not constructed correctly in ATSv2
> ----------------------------------------------------
>
> Key: YARN-7581
> URL: https://issues.apache.org/jira/browse/YARN-7581
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
> Affects Versions: 3.0.0-beta1
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-7581-YARN-7055.04.patch, YARN-7581.00.patch,
> YARN-7581.01.patch, YARN-7581.02.patch, YARN-7581.03.patch, YARN-7581.04.patch
>
>
> Post YARN-7346,
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters() and
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters()
> start to fail when hbase.profile is set to 2.0)
> *Error Message*
> [ERROR] Failures:
> [ERROR]
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters:1266
> expected:<2> but was:<0>
> [ERROR]
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters:1523
> expected:<1> but was:<0>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
