[ 
https://issues.apache.org/jira/browse/YARN-8018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408986#comment-16408986
 ] 

Chandni Singh commented on YARN-8018:
-------------------------------------

[~gsaha] thanks for the review. 
{quote}Is the new state supposed to be called UPGRADE or UPGRADING?
{quote}
None of the existing {{ServiceState}} are in present continuous including 
{{FLEX}} so I called it {{UPGRADE}}. I don't have a strong opinion here. I can 
change it to {{UPGRADING}}.
{quote}In inner class ComponentNeedsUpgradeTransition does the service state 
need to be updated in the transition method?
{quote}
The Service state will not be updated in this transition. 
 # The service state becomes {{UPGRADE}} in  
{{ServiceManager.StartUpgradeTransition}} 
 # The service state will become {{STABLE}} once the containers of all the 
component that need upgrade will be upgraded. The code for that will be in 
YARN-7939. 

I will provide a new patch to address rest of the comments.

> Yarn service: Add support for initiating service upgrade
> --------------------------------------------------------
>
>                 Key: YARN-8018
>                 URL: https://issues.apache.org/jira/browse/YARN-8018
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>            Priority: Major
>         Attachments: YARN-8018.001.patch, YARN-8018.002.patch, 
> YARN-8018.003.patch
>
>
> Add support for initiating service upgrade which includes the following main 
> changes:
>  # Service API to initiate upgrade
>  # Persist service version on hdfs
>  # Start the upgraded version of service



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to