[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410277#comment-16410277
]
Haibo Chen commented on YARN-7931:
----------------------------------
Thanks [~vrushalic] for the patch. The patch looks good overall. Some minor
comments:
1) Some comments in the DomainRowKey class is still referring to app_flow_table.
2) The DomainTable is missing writers as one of its columns. Also, let's add a
link of TimelineDomain documentation (possibly the apache official doc where it
is introduced).
3) I recall that we want to do compression on the domain table. Is that
something done at table creation time?
The other thing I am thinking is, whether do we want to think of the cases
where one application modifies domains posted by another application. This
seems allowed at the moment.
> [atsv2 read acls] Include domain table creation as part of schema creator
> -------------------------------------------------------------------------
>
> Key: YARN-7931
> URL: https://issues.apache.org/jira/browse/YARN-7931
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vrushali C
> Assignee: Vrushali C
> Priority: Major
> Attachments: YARN-7391.0001.patch
>
>
>
> Update the schema creator to create a domain table to store timeline entity
> domain info.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
