[ 
https://issues.apache.org/jira/browse/YARN-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418792#comment-16418792
 ] 

Sunil G commented on YARN-4781:
-------------------------------

Thanks [~eepayne]

I think changes are fine in top level. Few comments
 # The comparator used in this patch is considering used resource (- AM 
resource). However FairOrderingPolicy comparator also considers pending 
resource of an application. Do we need tat here?
 # Cud u pls check the findbugs warnings
 # Similar to testIntraQueuePreemptionFairOrderingPolicyMulitipleAppsPerUser, 
cud we also have a test where we have multiple apps are there per user. So 
among user's we ll select young app for preemption.

cc [~leftnoteasy]

> Support intra-queue preemption for fairness ordering policy.
> ------------------------------------------------------------
>
>                 Key: YARN-4781
>                 URL: https://issues.apache.org/jira/browse/YARN-4781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Major
>         Attachments: YARN-4781.001.patch, YARN-4781.002.patch
>
>
> We introduced fairness queue policy since YARN-3319, which will let large 
> applications make progresses and not starve small applications. However, if a 
> large application takes the queue’s resources, and containers of the large 
> app has long lifespan, small applications could still wait for resources for 
> long time and SLAs cannot be guaranteed.
> Instead of wait for application release resources on their own, we need to 
> preempt resources of queue with fairness policy enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to