[ 
https://issues.apache.org/jira/browse/YARN-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433090#comment-16433090
 ] 

Eric Payne commented on YARN-4781:
----------------------------------

bq. Hence in case we use sizeBasedWeight, we are considering pending as well. 
So i had this doubt..
I see what you mean. Good catch. I was not considering the {{sizeBasedWeight}} 
case. My first thought was to just use the 
{{FairOrderingPolicy#FairComparator}}, but that is for {{SchedulableEntity}}s 
like {{FiCaschedulingApp}}, and the {{PriorityQueue}}s in 
{{FifoIntraQueuePreemptionPlugin}} are sorting {{TempAppPerPartition}}s, so I 
wouldn't be able to combine this feature with the 
{{FifoIntraQueuePreemptionPlugin}}.

It may be worthwhile to go back to your previous suggestion about splitting out 
common functionality into an abstract {{AbstractIntraQueuePreemptionPlugin}} 
class and sub-classing FiFo and Fair puligins.

> Support intra-queue preemption for fairness ordering policy.
> ------------------------------------------------------------
>
>                 Key: YARN-4781
>                 URL: https://issues.apache.org/jira/browse/YARN-4781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Major
>         Attachments: YARN-4781.001.patch, YARN-4781.002.patch, 
> YARN-4781.003.patch
>
>
> We introduced fairness queue policy since YARN-3319, which will let large 
> applications make progresses and not starve small applications. However, if a 
> large application takes the queue’s resources, and containers of the large 
> app has long lifespan, small applications could still wait for resources for 
> long time and SLAs cannot be guaranteed.
> Instead of wait for application release resources on their own, we need to 
> preempt resources of queue with fairness policy enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to