[ 
https://issues.apache.org/jira/browse/YARN-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429411#comment-16429411
 ] 

Shane Kumpf commented on YARN-7667:
-----------------------------------

Thanks for the patch, [~ebadger]. Overall this looks good. I tested a few 
different values and can see the correct grace period being set in the cmd file 
and in the stop call in the docker daemon debug logs:
{code:java}
Apr 07 15:05:44 host dockerd[8987]: time="2018-04-07T15:05:44.577115114Z" 
level=debug msg="Calling POST 
/v1.37/containers/container_e01_1523113380632_0001_01_000002/stop?t=2"
Apr 07 15:05:44 host dockerd[8987]: time="2018-04-07T15:05:44.577396387Z" 
level=debug msg="Sending kill signal 15 to container 
3dd78436322153be5ee0437296e40bfd818fbc17b7015bc37db3d97d977fc0a1"
Apr 07 15:05:46 host dockerd[8987]: time="2018-04-07T15:05:46.596738936Z" 
level=info msg="Container 
3dd78436322153be5ee0437296e40bfd818fbc17b7015bc37db3d97d977fc0a1 failed to exit 
within 2 seconds of signal 15 - using the force"{code}
Couple minor comments on the patch:
 # Is there a reason not to set the value for 
{{yarn.nodemanager.runtime.linux.docker.stop.grace-period}} in 
{{yarn-default.xml}} to 10?
 # I don't think the new {{DockerStopCommand}} constructor is necessary, {{new 
DockerStopCommand(containerId).setGracePeriod(dockerStopGracePeriod)}} would 
achieve the same.

> Docker Stop grace period should be configurable
> -----------------------------------------------
>
>                 Key: YARN-7667
>                 URL: https://issues.apache.org/jira/browse/YARN-7667
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-7667.001.patch, YARN-7667.002.patch, 
> YARN-7667.003.patch
>
>
> {{DockerStopCommand}} has a {{setGracePeriod}} method, but it is never 
> called. So, the stop uses the 10 second default grace period from docker



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to