Eric Badger commented on YARN-7667:

[~shaneku...@gmail.com], thanks for the review! 

bq. Is there a reason not to set the value for 
yarn.nodemanager.runtime.linux.docker.stop.grace-period in yarn-default.xml to 
Not particularly. I was just leaving it to be set by the user while using the 
default value set in YarnConfiguration. I'm not sure on the convention there, 
so I went ahead and followed your comment and updated the default in 
yarn-default.xml to 10. 

bq. I don't think the new DockerStopCommand constructor is necessary, new 
DockerStopCommand(containerId).setGracePeriod(dockerStopGracePeriod) would 
achieve the same.
Fair enough. I removed the additional constructor and replaced the invocations 
with {{DockerStopCommand(containerId).setGracePeriod(dockerStopGracePeriod)}}

> Docker Stop grace period should be configurable
> -----------------------------------------------
>                 Key: YARN-7667
>                 URL: https://issues.apache.org/jira/browse/YARN-7667
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-7667.001.patch, YARN-7667.002.patch, 
> YARN-7667.003.patch, YARN-7667.004.patch
> {{DockerStopCommand}} has a {{setGracePeriod}} method, but it is never 
> called. So, the stop uses the 10 second default grace period from docker

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to