[ 
https://issues.apache.org/jira/browse/YARN-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445952#comment-16445952
 ] 

Billie Rinaldi commented on YARN-8122:
--------------------------------------

[~gsaha], thanks for addressing my previous comments. I have one additional 
item I'd like to discuss, now that I have refamiliarized myself with the 
Component/ComponentInstance code. I think we should consider whether or not 
ComponentHealthThresholdMonitor should be a service that is added into the AM 
CompositeService. For example, we are [scheduling the ContainerStatusRetriever 
in the ServiceScheduler's thread 
pool|https://github.com/apache/hadoop/blob/branch-3.1.0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/component/instance/ComponentInstance.java#L146-L149].
 We could be doing the same thing with the health threshold monitor tasks. This 
would have the advantage of not creating a separate thread pool for each 
component, when we don't know how many components the service might have.

> Component health threshold monitor
> ----------------------------------
>
>                 Key: YARN-8122
>                 URL: https://issues.apache.org/jira/browse/YARN-8122
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gour Saha
>            Assignee: Gour Saha
>            Priority: Major
>         Attachments: YARN-8122.001.patch, YARN-8122.002.patch, 
> YARN-8122.003.patch, YARN-8122.004.patch, YARN-8122.draft.patch
>
>
> Slider supported component health threshold monitoring with SLIDER-1246. It 
> would be good to have this feature for YARN Service too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to