[
https://issues.apache.org/jira/browse/YARN-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449311#comment-16449311
]
genericqa commented on YARN-7892:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} YARN-3409 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m
33s{color} | {color:green} YARN-3409 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
9s{color} | {color:green} YARN-3409 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} YARN-3409 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
48s{color} | {color:green} YARN-3409 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 30s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
23s{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in
YARN-3409 has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
54s{color} | {color:green} YARN-3409 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 10m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
37s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 26s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 12 new + 168 unchanged - 0 fixed = 180 total (was 168) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 4m
39s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
37s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
44s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 22s{color}
| {color:red} hadoop-yarn-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 21m
33s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 40s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 27m
36s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}230m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs |
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
|
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.getResourceByAttribute(NodeAttribute)
At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.getResourceByAttribute(NodeAttribute)
At NodeAttributesManagerImpl.java:[line 397] |
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.removeNodeFromAttributes(String,
Set) At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.removeNodeFromAttributes(String,
Set) At NodeAttributesManagerImpl.java:[line 214] |
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.removeNodeFromAttributes(String,
Set) At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.removeNodeFromAttributes(String,
Set) At NodeAttributesManagerImpl.java:[line 220] |
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.activateNode(NodeId,
Resource) At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.activateNode(NodeId,
Resource) At NodeAttributesManagerImpl.java:[line 480] |
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.deactivateNode(NodeId)
At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.deactivateNode(NodeId)
At NodeAttributesManagerImpl.java:[line 492] |
| | org.apache.hadoop.yarn.api.records.NodeAttribute is incompatible with
expected argument type org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.getResourceByAttribute(NodeAttribute)
At NodeAttributesManagerImpl.java:argument type
org.apache.hadoop.yarn.api.records.NodeAttributeID in
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.NodeAttributesManagerImpl.getResourceByAttribute(NodeAttribute)
At NodeAttributesManagerImpl.java:[line 398] |
| Failed junit tests | hadoop.yarn.api.TestPBImplRecords |
| | hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
|
| | hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
| | hadoop.yarn.server.resourcemanager.nodelabels.TestNodeAttributesManager |
| | hadoop.yarn.server.resourcemanager.rmapp.TestApplicationLifetimeMonitor |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b |
| JIRA Issue | YARN-7892 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920384/YARN-7892-YARN-3409.003.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle cc |
| uname | Linux 2aef8c4c6d31 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | YARN-3409 / 341094c |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
|
| unit |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/testReport/ |
| Max. process+thread count | 829 (vs. ulimit of 10000) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U:
hadoop-yarn-project/hadoop-yarn |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/20448/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Revisit NodeAttribute class structure
> -------------------------------------
>
> Key: YARN-7892
> URL: https://issues.apache.org/jira/browse/YARN-7892
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: YARN-7892-YARN-3409.001.patch,
> YARN-7892-YARN-3409.002.patch, YARN-7892-YARN-3409.003.WIP.patch,
> YARN-7892-YARN-3409.003.patch
>
>
> In the existing structure, we had kept the type and value along with the
> attribute which would create confusion to the user to understand the APIs as
> they would not be clear as to what needs to be sent for type and value while
> fetching the mappings for node(s).
> As well as equals will not make sense when we compare only for prefix and
> name where as values for them might be different.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
