[ 
https://issues.apache.org/jira/browse/YARN-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462276#comment-16462276
 ] 

Bibin A Chundatt commented on YARN-7892:
----------------------------------------

[~Naganarasimha]

Please find the comments

# For both getClusterAttributes and getAttributes to node we are iterating over 
all the attribute ids two times. Can we optimize the same ?
{code}
57        @Override
58        public String getAttributePrefix() {
59          NodeAttributeIDProtoOrBuilder p = viaProto ? proto : builder;
60          if (!p.hasAttributePrefix()) {
61            return null;
62          }
63          return p.getAttributePrefix();
64        }
{code}
# The default value should be either empty/CENTRLIZED rt ?? 
# getCluster attrributes,Get Nodes to Attributes, Get Attributes to Node IIUC 
we should return unmodifiable collection
# Can you update the java docs for all API's since the signature is changed.
# Test case failures looks related please handle the same.



> Revisit NodeAttribute class structure
> -------------------------------------
>
>                 Key: YARN-7892
>                 URL: https://issues.apache.org/jira/browse/YARN-7892
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-7892-YARN-3409.001.patch, 
> YARN-7892-YARN-3409.002.patch, YARN-7892-YARN-3409.003.WIP.patch, 
> YARN-7892-YARN-3409.003.patch, YARN-7892-YARN-3409.004.patch, 
> YARN-7892-YARN-3409.005.patch
>
>
> In the existing structure, we had kept the type and value along with the 
> attribute which would create confusion to the user to understand the APIs as 
> they would not be clear as to what needs to be sent for type and value while 
> fetching the mappings for node(s).
> As well as equals will not make sense when we compare only for prefix and 
> name where as values for them might be different.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to