[ 
https://issues.apache.org/jira/browse/YARN-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454579#comment-16454579
 ] 

Wangda Tan commented on YARN-8213:
----------------------------------

Thanks [~cheersyang], took a quick look, haven't checked details of the patch.

{code} 
1220        CapacitySchedulerMetrics.destroy();
{code} 

We shouldn't add CS-specific logics to RM. I think we should add an abstract 
SchedulerMetrics to: a. pull common scheduler metrics to the base class. b. 
avoid RM depends on any class of scheduler. 

[~ywskycn] was working on some CS related metrics changes, he may have some 
thoughts. 

> Add Capacity Scheduler metrics
> ------------------------------
>
>                 Key: YARN-8213
>                 URL: https://issues.apache.org/jira/browse/YARN-8213
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler, metrics
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Critical
>         Attachments: YARN-8213.001.patch, YARN-8213.002.patch
>
>
> Currently when tune CS performance, it is not that straightforward because 
> lacking of metrics. Right now we only have \{{QueueMetrics}} which mostly 
> only tracks queue level resource counters. Propose to add CS metrics to 
> collect and display more fine-grained perf metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to