[
https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462638#comment-16462638
]
Haibo Chen commented on YARN-7933:
----------------------------------
Thanks [~rohithsharma] for updating the patch! Looks good to me in general. I
have a few questions:
1) Does the patch require a domain id for every timelineEntity? Or what happens
if no domain id set?
2) The /domain endpoint takes appId as a query param. Is it the same as the app
id in the TimelineCollector context?
3) Does it make sense in this patch to add in memory cache of domain in
TimelineCollector? Given the patch deals with the write path, probably so.
4) In HBaseTimelineWriterImpl, null-checking is done solely for clusterId. Do
we need to check for domainId as well? This goes back to 1)
> [atsv2 read acls] Add TimelineWriter#writeDomain
> -------------------------------------------------
>
> Key: YARN-7933
> URL: https://issues.apache.org/jira/browse/YARN-7933
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vrushali C
> Assignee: Rohith Sharma K S
> Priority: Major
> Attachments: YARN-7933.01.patch, YARN-7933.02.patch,
> YARN-7933.03.patch, YARN-7933.04.patch
>
>
>
> Add an API TimelineWriter#writeDomain for writing the domain info
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
