[ https://issues.apache.org/jira/browse/YARN-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472564#comment-16472564 ]
Shane Kumpf commented on YARN-8141: ----------------------------------- {quote}{{AbstractLauncher}} in Yarn service while creating the {{LaunchContext}} doesn't know about the absolute path of the localized resource. \{quote} This is true, but that is the case with the current code path as well. Resolving the absolute path to the localized resource is handled on the runtime side. I believe we could still consolidate by having {{YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS}} support both relative and absolute source paths (with the difference in behavior documented). If the source path is relative, it is assumed to be a localized resource and is then passed to validateMount which validates and returns the absolute path to that localized resource. If it an absolute path, the mount is added as-is. Do you see any issues with that approach? Does that still meet your original need [~leftnoteasy]? > YARN Native Service: Respect > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS specified in service spec > ---------------------------------------------------------------------------------------------------------- > > Key: YARN-8141 > URL: https://issues.apache.org/jira/browse/YARN-8141 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn-native-services > Reporter: Wangda Tan > Assignee: Chandni Singh > Priority: Critical > Attachments: YARN-8141.001.patch, YARN-8141.002.patch, > YARN-8141.003.patch > > > Existing YARN native service overwrites > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS regardless if user > specified this in service spec or not. It is important to allow user to mount > local folders like /etc/passwd, etc. > Following logic overwrites the > YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS environment: > {code:java} > StringBuilder sb = new StringBuilder(); > for (Entry<String,String> mount : mountPaths.entrySet()) { > if (sb.length() > 0) { > sb.append(","); > } > sb.append(mount.getKey()); > sb.append(":"); > sb.append(mount.getValue()); > } > env.put("YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS", > sb.toString());{code} > Inside AbstractLauncher.java -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org