[ 
https://issues.apache.org/jira/browse/YARN-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478311#comment-16478311
 ] 

Eric Yang commented on YARN-8141:
---------------------------------

[~csingh] Thank you for the patch, a few nits:

FindAbsoluteMount method can be skipped.  Container-executor looks up source 
mount location and comparing the absolute path to the white list mount 
(YARN-5534).

DockerContainers.md still have reference to 
YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS.  This can be removed as 
well.

> YARN Native Service: Respect 
> YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS specified in service spec
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8141
>                 URL: https://issues.apache.org/jira/browse/YARN-8141
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn-native-services
>            Reporter: Wangda Tan
>            Assignee: Chandni Singh
>            Priority: Critical
>              Labels: Docker
>         Attachments: YARN-8141.001.patch, YARN-8141.002.patch, 
> YARN-8141.003.patch, YARN-8141.004.patch
>
>
> Existing YARN native service overwrites 
> YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS regardless if user 
> specified this in service spec or not. It is important to allow user to mount 
> local folders like /etc/passwd, etc.
> Following logic overwrites the 
> YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS environment:
> {code:java}
> StringBuilder sb = new StringBuilder();
> for (Entry<String,String> mount : mountPaths.entrySet()) {
>   if (sb.length() > 0) {
>     sb.append(",");
>   }
>   sb.append(mount.getKey());
>   sb.append(":");
>   sb.append(mount.getValue());
> }
> env.put("YARN_CONTAINER_RUNTIME_DOCKER_LOCAL_RESOURCE_MOUNTS", 
> sb.toString());{code}
> Inside AbstractLauncher.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to