Sushil Kumar S commented on YARN-8270:

Hi Haibo, thanks for reviewing please find my comments below,

1) Yes the collector metric is an aggregate for all collectors on the same node 
i.e on all NM and RM
2) Do you mean separate metrics by *TimelineEntityType*? like YARN_APPLICATION, 
3) My bad its actually private, sure makes sense will make it *update*Metrics()

4) I made use of *double checked locking pattern*  for getInstance() is it 
still not thread-safe?

> Adding JMX Metrics for Timeline Collector and Reader
> ----------------------------------------------------
>                 Key: YARN-8270
>                 URL: https://issues.apache.org/jira/browse/YARN-8270
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: ATSv2, timelineserver
>            Reporter: Sushil Kumar S
>            Assignee: Sushil Kumar S
>            Priority: Major
>         Attachments: YARN-8270.001.patch
> This Jira is for emitting JMX Metrics for ATS v2 Timeline Collector and 
> Timeline Reader, basically for Timeline Collector it tries to capture 
> success, failure and latencies for *putEntities* and *putEntitiesAsync*  from 
> *TimelineCollectorWebService* and all the API's success, failure and 
> latencies for fetching TimelineEntities from *TimelineReaderWebServices*. 
> This would actually help in monitoring and measuring performance for ATSv2 at 
> scale.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to