[ 
https://issues.apache.org/jira/browse/YARN-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497071#comment-16497071
 ] 

Sunil Govindan commented on YARN-8258:
--------------------------------------

Yes [~vinodkv]

UI2 was missing the filters when compared to what is added in to default 
context. {{httpServer.getWebAppContext().getServletHandler()}} was providing 
all filterHolding and filterMappings with {{getFilters}} and 
{{getFilterMappings}} apis. To define filter for Ui2, we have to iterate 
through the list of filterHolder available via {{getFilters}} api and call 
{{HttpServer2.defineFilter}}. While doing this, {{getFilterMappings}} helps to 
get the URL path associated with each filter name and UI2 also should use same 
except for *authentication* filter. In that case, UI2 has to add /*.

With this change, if a custom filter is added such as AuthenticationFIlter or 
JWTAuthHandler, UI2 context will have the servlet details and with correct 
path. 

> YARN webappcontext for UI2 should inherit all filters from default context
> --------------------------------------------------------------------------
>
>                 Key: YARN-8258
>                 URL: https://issues.apache.org/jira/browse/YARN-8258
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: webapp
>            Reporter: Sumana Sathish
>            Assignee: Sunil Govindan
>            Priority: Major
>         Attachments: YARN-8258.001.patch, YARN-8258.002.patch, 
> YARN-8258.003.patch
>
>
> Thanks [~ssath...@hortonworks.com] for finding this.
> Ideally all filters from default context has to be inherited to UI2 context 
> as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to