[
https://issues.apache.org/jira/browse/YARN-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501263#comment-16501263
]
Vinod Kumar Vavilapalli commented on YARN-8258:
-----------------------------------------------
bq. While doing this, getFilterMappings helps to get the URL path associated
with each filter name and UI2 also should use same except for authentication
filter. In that case, UI2 has to add /*.
What is special about authentication filter? Can you comment on why every
filter can be copied as is? If it is special, let's add java comment too.
WebApps is a generic utility in hadoop-yarn-common, so it's weird for it to
have RM specific code. We should look at cleaning this class up by moving RM
specific code into RM itself.
After that, can you make {{addFiltersForUI2Context()}} static and move to
RMWebAppUtil?
Refactor the string "authentication" in AuthenticationFilterInitializer and
reuse it.
The following can lose multiple filters in the array with the same name. Is
that okay?
{code}
Map<String, FilterMapping> filterMappings = new HashMap<>();
for (FilterMapping filterMapping : filterMappingsArray) {
filterMappings.put(filterMapping.getFilterName(), filterMapping);
}
{code}
> YARN webappcontext for UI2 should inherit all filters from default context
> --------------------------------------------------------------------------
>
> Key: YARN-8258
> URL: https://issues.apache.org/jira/browse/YARN-8258
> Project: Hadoop YARN
> Issue Type: Bug
> Components: webapp
> Reporter: Sumana Sathish
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-8258.001.patch, YARN-8258.002.patch,
> YARN-8258.003.patch, YARN-8258.004.patch, YARN-8258.005.patch
>
>
> Thanks [[email protected]] for finding this.
> Ideally all filters from default context has to be inherited to UI2 context
> as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
