[
https://issues.apache.org/jira/browse/YARN-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501253#comment-16501253
]
Weiwei Yang commented on YARN-8103:
-----------------------------------
Hi [~bibinchundatt]
The patch overall looks good to me, some comments below
ClusterCLI
* line 121: printClusterNodeAttributes() writer is not closed
NodeAttributesCLI
* line 299: nodestoattributes -> nodes2attributes
* line 302: attributestonodes -> attributes2nodes
* line 149, 374, 421: ByteArrayOutputStream is not closed
* line 588: buildNodeLabelsMapFromStr -> buildNodeAttributesListFromStr
NodeCLI
* line 349: why not to call NodeAttribute#toString?
Thanks
> Add CLI interface to query node attributes
> -------------------------------------------
>
> Key: YARN-8103
> URL: https://issues.apache.org/jira/browse/YARN-8103
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8103-YARN-3409.001.patch,
> YARN-8103-YARN-3409.002.patch, YARN-8103-YARN-3409.WIP.patch
>
>
> YARN-8100 will add API interface for querying the attributes. CLI interface
> for querying node attributes for each nodes and list all attributes in
> cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
