[
https://issues.apache.org/jira/browse/YARN-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516100#comment-16516100
]
Naganarasimha G R commented on YARN-8103:
-----------------------------------------
Thanks for the patch [~bibinchundatt]
Some of my comments seems to be still not addressed:
* NodeAttributesCLI ln no 187: i think its better to use null here instead of
"handler" for better readability
* TestNodeAttributesCLI ln no 405: testListAttributes is encapsulating
NodesToAttributes tests too, may be it can captured as a different case
* NodeCLI ln no 317 : IMO it would better to wrap each attribute in a new
line ?
And some of the [~cheersyang] comments needs to be discussed (though i am not
more towards numeric form for to but we can discuss other better options)
and this comment needs to be handled
* line 588: buildNodeLabelsMapFromStr -> buildNodeAttributesListFromStr
Apart from this many of the Checkstyle issues still seems to be valid and needs
to be addressed.
> Add CLI interface to query node attributes
> -------------------------------------------
>
> Key: YARN-8103
> URL: https://issues.apache.org/jira/browse/YARN-8103
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8103-YARN-3409.001.patch,
> YARN-8103-YARN-3409.002.patch, YARN-8103-YARN-3409.003.patch,
> YARN-8103-YARN-3409.WIP.patch
>
>
> YARN-8100 will add API interface for querying the attributes. CLI interface
> for querying node attributes for each nodes and list all attributes in
> cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
