[
https://issues.apache.org/jira/browse/YARN-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507027#comment-16507027
]
Abhishek Modi commented on YARN-7953:
-------------------------------------
Thanks [~botong] for the review. I have attached v5 patch fixing these.
{quote}line 160, super.clone() is redundant.
{quote}
super.clone needs to be called, else checkstyle check gives warning.
{quote}line 47, this is a tree of queues rather than a single queue right?
{quote}
It represents details about one queue and contains references of children
queues. Since it is inspired from Capacity Scheduler and Fair Scheduler queues
and that also has similar concept, in my opinion it's better to keep it as a
queue.
> [GQ] Data structures for federation global queues calculations
> --------------------------------------------------------------
>
> Key: YARN-7953
> URL: https://issues.apache.org/jira/browse/YARN-7953
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Carlo Curino
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-7953-YARN-7402.v1.patch,
> YARN-7953-YARN-7402.v2.patch, YARN-7953-YARN-7402.v3.patch,
> YARN-7953-YARN-7402.v4.patch, YARN-7953.v1.patch
>
>
> This Jira tracks data structures and helper classes used by the core
> algorithms of YARN-7402 umbrella Jira (currently YARN-7403, and YARN-7834).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
