[ 
https://issues.apache.org/jira/browse/YARN-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507115#comment-16507115
 ] 

Botong Huang commented on YARN-7953:
------------------------------------

bq. line 160, super.clone() is redundant.
Then either use the object from _rationGlobalView) super.clone()_ with 
necessary modification (deep copy), or remove cloneable interface and change 
signature to _static clone()_ then. Basically avoid creating new two copied 
objects and using only one. 

bq. line 47, this is a tree of queues rather than a single queue right?
Agreed. What I meant is the javadoc description: 
This class represent a queue at the federation level -> This class represent a 
tree of queues in a sub-cluster YarnRM. 

> [GQ] Data structures for federation global queues calculations
> --------------------------------------------------------------
>
>                 Key: YARN-7953
>                 URL: https://issues.apache.org/jira/browse/YARN-7953
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-7953-YARN-7402.v1.patch, 
> YARN-7953-YARN-7402.v2.patch, YARN-7953-YARN-7402.v3.patch, 
> YARN-7953-YARN-7402.v4.patch, YARN-7953-YARN-7402.v5.patch, YARN-7953.v1.patch
>
>
> This Jira tracks data structures and helper classes used by the core 
> algorithms of YARN-7402 umbrella Jira (currently YARN-7403, and YARN-7834).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to