[
https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524206#comment-16524206
]
Szilard Nemeth commented on YARN-7556:
--------------------------------------
Hi again!
About my last comment:
I wasn't aware that this line in the constructor of {{LightWeightResource }}
sets memory/vcores to the provided value correctly, so that comment can be
disregarded:
{code:java}
initResourceInformations(value, value, types.length);
{code}
According to our offline discussion with [~templedf], I'm taking this over.
My new patch includes these fixes / modifications on top of patch 007:
- Some formatting fixes in LightWeightResource
- Rename a local variable in ConfigurableResource#getOneHundredPercentArray
- FairSchedulerConfiguration: readability improvements / code cleanup
[~haibochen]: This is ready for review!
If you commit this, please don't forget to mention Daniel's name as I only
contributed to the latest patch.
Thanks!
> Fair scheduler configuration should allow resource types in the minResources
> and maxResources properties
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-7556
> URL: https://issues.apache.org/jira/browse/YARN-7556
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 3.0.0-beta1
> Reporter: Daniel Templeton
> Assignee: Szilard Nemeth
> Priority: Critical
> Attachments: YARN-7556.001.patch, YARN-7556.002.patch,
> YARN-7556.003.patch, YARN-7556.004.patch, YARN-7556.005.patch,
> YARN-7556.006.patch, YARN-7556.007.patch, YARN-7556.008.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
