[
https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533975#comment-16533975
]
Wangda Tan commented on YARN-7556:
----------------------------------
[~haibochen], [~templedf], [~snemeth],
I was thinking to post some comments but the patch already went through :).
I don't prefer to change the common classes (like Resource/LightWeightResource)
to add the functionality of setting all resource types to same value.
The API looks really confusing:
We have:
{code}
@Public
@Stable
public static Resource newInstance(long memory, int vCores) {
return new LightWeightResource(memory, vCores);
}
{code}
But the new added method has the same first parameter signature (long value)
but completely different semantics.
If you really want to add to common layer and reused in other places, I suggest
to add it to Resources with method name like {{createResourceWithSameValue}}.
> Fair scheduler configuration should allow resource types in the minResources
> and maxResources properties
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-7556
> URL: https://issues.apache.org/jira/browse/YARN-7556
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 3.0.0-beta1
> Reporter: Daniel Templeton
> Assignee: Szilard Nemeth
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: YARN-7556.001.patch, YARN-7556.002.patch,
> YARN-7556.003.patch, YARN-7556.004.patch, YARN-7556.005.patch,
> YARN-7556.006.patch, YARN-7556.007.patch, YARN-7556.008.patch,
> YARN-7556.009.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
