[ 
https://issues.apache.org/jira/browse/YARN-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550865#comment-16550865
 ] 

Hudson commented on YARN-8528:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14600 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14600/])
YARN-8528. Final states in ContainerAllocation might be modified (wwei: rev 
cbf20264838f536382a9d8c4cd2144faf6875c3a)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/ContainerAllocation.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/allocator/RegularContainerAllocator.java


> Final states in ContainerAllocation might be modified externally causing 
> unexpected allocation results
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8528
>                 URL: https://issues.apache.org/jira/browse/YARN-8528
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>            Reporter: Xintong Song
>            Assignee: Xintong Song
>            Priority: Major
>             Fix For: 3.2.0, 3.1.1
>
>         Attachments: YARN-8528.001.patch
>
>
> ContainerAllocation.LOCALITY_SKIPPED is final static, and its .state should 
> always be AllocationState.LOCALITY_SKIPPED. However, this variable is public 
> and is accidentally changed to AllocationState.APP_SKIPPED in 
> RegularContainerAllocator under certain conditions. Once that happens, all 
> following LOCALITY_SKIPPED situations will be treated as APP_SKIPPED.
> Similar risks exist for 
> ContainerAllocation.PRIORITY_SKIPPED/APP_SKIPPED/QUEUE_SKIPPED. 
> ContainerAllocation.state should be private and should not be changed. If 
> changes are needed, a new ContainerAllocation should be created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to