[ 
https://issues.apache.org/jira/browse/YARN-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562350#comment-16562350
 ] 

Wangda Tan commented on YARN-8528:
----------------------------------

Updated fixed version to 3.1.2 given this don't exist in branch-3.1.1.
But I think it is important to get it backported to branch-3.1.1, I'm going to 
do this in a couple of hours, please let me know if you think different.

cc: [~cheersyang]

> Final states in ContainerAllocation might be modified externally causing 
> unexpected allocation results
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8528
>                 URL: https://issues.apache.org/jira/browse/YARN-8528
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>            Reporter: Xintong Song
>            Assignee: Xintong Song
>            Priority: Major
>             Fix For: 3.2.0, 3.1.2
>
>         Attachments: YARN-8528.001.patch
>
>
> ContainerAllocation.LOCALITY_SKIPPED is final static, and its .state should 
> always be AllocationState.LOCALITY_SKIPPED. However, this variable is public 
> and is accidentally changed to AllocationState.APP_SKIPPED in 
> RegularContainerAllocator under certain conditions. Once that happens, all 
> following LOCALITY_SKIPPED situations will be treated as APP_SKIPPED.
> Similar risks exist for 
> ContainerAllocation.PRIORITY_SKIPPED/APP_SKIPPED/QUEUE_SKIPPED. 
> ContainerAllocation.state should be private and should not be changed. If 
> changes are needed, a new ContainerAllocation should be created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to