[ https://issues.apache.org/jira/browse/YARN-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771411#comment-13771411 ]
Karthik Kambatla commented on YARN-1068: ---------------------------------------- Having a separate RMHAAdminService allows handling it through the super.service*() calls in RMHAProtocolService. This makes it very simple to create a RMHAProtocolService without the admin parts without having to override all its service*() calls. In the current patch, MockRM does the following. If it was all in one RMHAService, this will be much longer and needs to be updated everytime the actual RMHAService service* methods get updated. Also, don't see particular downside to having it as a separate service except that it is class. The RM itself still sees a single service in RMHAProtocolService. {code} protected RMHAProtocolService createRMHAProtocolService() { return new RMHAProtocolService(this) { @Override protected RMHAAdminService createRMHAAdminService() { return null; } }; } {code} > Add admin support for HA operations > ----------------------------------- > > Key: YARN-1068 > URL: https://issues.apache.org/jira/browse/YARN-1068 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.1.0-beta > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Labels: ha > Attachments: yarn-1068-1.patch, yarn-1068-2.patch, yarn-1068-3.patch, > yarn-1068-4.patch, yarn-1068-prelim.patch > > > Support HA admin operations to facilitate transitioning the RM to Active and > Standby states. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira