[ https://issues.apache.org/jira/browse/YARN-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773296#comment-13773296 ]
Bikas Saha commented on YARN-1068: ---------------------------------- If I understand this correctly, the jira is adding RPC server support for HAServiceProtocol on the server side and client support for admins. The RPC server is meant for the HAServiceProtocol. Why do we need to create an RMHAAdminService? This RPC server should simply be embedded in the existing RMHAServiceProtocol that logically implements the HAServiceProtocol. Isnt that needed for ZKFC (and other clients like the admin cli) to connect to the RM and issue transitions commands? Other protocol servers are embedded similarly in the RM. e.g. ApplicationMasterService creates the ApplicationMasterProtocol RPC server and passes itself into the RPC server for callbacks. The client side code should probably be invoked via RMProxy like the other protocols are accessed today. In a failover setup the following may not be valid. {code} + RMHAServiceTarget() { + YarnConfiguration targetConf = new YarnConfiguration(getConf()); + haAdminServiceAddress = targetConf.getSocketAddr( + YarnConfiguration.RM_HA_ADMIN_ADDRESS, + YarnConfiguration.DEFAULT_RM_HA_ADMIN_ADDRESS, + YarnConfiguration.DEFAULT_RM_HA_ADMIN_PORT); {code} > Add admin support for HA operations > ----------------------------------- > > Key: YARN-1068 > URL: https://issues.apache.org/jira/browse/YARN-1068 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.1.0-beta > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Labels: ha > Attachments: yarn-1068-1.patch, yarn-1068-2.patch, yarn-1068-3.patch, > yarn-1068-4.patch, yarn-1068-prelim.patch > > > Support HA admin operations to facilitate transitioning the RM to Active and > Standby states. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira