[
https://issues.apache.org/jira/browse/YARN-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634751#comment-16634751
]
Szilard Nemeth commented on YARN-8732:
--------------------------------------
Couple of changes with the new patch004:
1. Javadoc added for new test classes
2. Test annotation added to testValidateRequestCapacityAgainstMinMaxAllocation
/ testRequestCapacityMinMaxAllocationForResourceTypes to the base test class,
so I can avoid having all testcases calling super.<methodX> for every abstract
test method.
3. As a consequence of 2., the queue name for CS / FS test classes are now
provided by the implementors of the abstract method from the base class.
4. The atomic integer fields are moved to TestApplicationMasterInterceptor as
they were used exclusively by this class.
5. TestApplicationMasterInterceptor is no longer a subclas of
ApplicationMasterServiceTestBase, as it have not used any helper methods and
only required a configuration instance to be present. Moreover, it is
semantically different from the CS / FS test classes.
> Add unit tests of min/max allocation for custom resource types in
> FairScheduler
> -------------------------------------------------------------------------------
>
> Key: YARN-8732
> URL: https://issues.apache.org/jira/browse/YARN-8732
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Labels: unittest
> Attachments: YARN-8732.001.patch, YARN-8732.002.patch,
> YARN-8732.003.patch, YARN-8732.004.patch
>
>
> Create testcase like this, but for FS:
> org.apache.hadoop.yarn.server.resourcemanager.TestApplicationMasterService#testValidateRequestCapacityAgainstMinMaxAllocationFor3rdResourceTypes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
