[
https://issues.apache.org/jira/browse/YARN-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635866#comment-16635866
]
Haibo Chen commented on YARN-8732:
----------------------------------
Thanks [~snemeth] for the patch! I have a few comments.
1) sentRMContainerLaunched() is called exclusively in
TestApplicationMasterServiceCapacity, so better move it to
TestApplicationMasterServiceCapacity.
2) testResourceTypes() checks all three schedulers, fifo, capacity scheduler
and fair scheduler. How about we split them into three classes respectively,
even though it might mean some code duplication?
3) testUpdateTrackingUrl() is now run for capacity scheduler only. I think we
shall run it with all three schedulers. So is
testInvalidIncreaseDecreaseRequest() in theory (If the other two schedulers do
not support increase/decrease requests, let's keep it with capacity scheduler
only.
4) requestMemory() and requestVcore() can be consolidated into one method that
takes both vcore and memory as its parameters.
5) TestApplicationMasterInterceptor has dependency on
ApplicationMasterServiceTestBase.GB. Can we just add the same field in
TestApplicationMasterInterceptor and remove that dependency?
6) Instead of "Application Master test class, testing Fair Scheduler behavior."
in the TestApplicationMasterServiceFair class javadoc, can we rephrase as "Unit
tests for \{@link ApplicationMasterService} with \{@link FairScheduler}". I
don't think we are testing Fair Scheduler behavior directly per se. Likewise
for the other two classes.
7) All the unit tests in ApplicationMasterServiceTestBase are applicable to all
three schedulers, but we are just running them with Fifo scheduler. We should
probably enable them for capacity and fair scheduler too.
> Add unit tests of min/max allocation for custom resource types in
> FairScheduler
> -------------------------------------------------------------------------------
>
> Key: YARN-8732
> URL: https://issues.apache.org/jira/browse/YARN-8732
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Labels: unittest
> Attachments: YARN-8732.001.patch, YARN-8732.002.patch,
> YARN-8732.003.patch, YARN-8732.004.patch, YARN-8732.005.patch
>
>
> Create testcase like this, but for FS:
> org.apache.hadoop.yarn.server.resourcemanager.TestApplicationMasterService#testValidateRequestCapacityAgainstMinMaxAllocationFor3rdResourceTypes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
