[
https://issues.apache.org/jira/browse/YARN-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660082#comment-16660082
]
Sunil Govindan commented on YARN-8873:
--------------------------------------
Hi [~cheersyang]
I wad going through this patch during my tests. I have some doubts on few
parts. Kindly help to check.
1. CsiClientImpl#CsiClientImpl() ctor. In this ctor,
*GrpcHelper.getSocketAddress* can throw exception. For client creation time, if
an exception comes, will it be more difficult to handle? I am thinking whether
we need to have an init, start etc for this client to handle such improvements.
2. In CsiClientImpl#getPluginInfo, i can see only a try statement. proper error
handling needed for logging or audit purpose etc?
3. In CsiGrpcClient#close call, will EpollEventLoopGroup also be closed along
with channel termination internally?
4. In GrpcHelper#getSocketAddress, unix socket path file permission need to be
checked? or can we isolate this and throw valid error for user if they miss
during setup?
Thank you.
> Add CSI java-based client library
> ---------------------------------
>
> Key: YARN-8873
> URL: https://issues.apache.org/jira/browse/YARN-8873
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8873.001.patch, YARN-8873.002.patch,
> YARN-8873.003.patch, YARN-8873.004.patch, YARN-8873.005.patch,
> YARN-8873.006.patch
>
>
> Build a java-based client to talk to CSI drivers, through CSI gRPC services.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
