[
https://issues.apache.org/jira/browse/YARN-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660115#comment-16660115
]
Weiwei Yang commented on YARN-8873:
-----------------------------------
Hi [~sunilg]
Thanks for the comments, pls see my thoughts
#1 GrpcHelper.getSocketAddress will throw IllegalArgumentException when socket
address is not valid, this is not a recoverable exception, I think we should
let RM/NM (where uses this client) to fail-fast when such configuration issue
is found.
#2 Good suggestion, I think we should add some DEBUG logging to track what
client is doing. If you are OK with that, I can add that in next patch as the
change is trivial.
#3 When the ManagedChannel is stopped, it will shutdown the
ClientTransportFactory (the EpollEventLoopGroup is part of the factory so it
will be stopped). So no worries about leaking resource.
#4 My initial patch actually has the permission check, but I then found netty
already did the check when it creates the channel, so I removed that.
Thanks
> Add CSI java-based client library
> ---------------------------------
>
> Key: YARN-8873
> URL: https://issues.apache.org/jira/browse/YARN-8873
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8873.001.patch, YARN-8873.002.patch,
> YARN-8873.003.patch, YARN-8873.004.patch, YARN-8873.005.patch,
> YARN-8873.006.patch
>
>
> Build a java-based client to talk to CSI drivers, through CSI gRPC services.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
