[ 
https://issues.apache.org/jira/browse/YARN-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661236#comment-16661236
 ] 

Chandni Singh commented on YARN-8672:
-------------------------------------

{quote}
I believe the patch will fix the issue but cause another issue in the process. 
If I'm reading it properly, canceling a localizer will leak the localizer's 
token files. For example, if a container is in the process of localizing and 
gets killed, we will cancel the localizer which will prevent the tokens file 
from being deleted. I'd expect localizer tokens to pile up as a result.
{quote}

[~jlowe] Yes you are right. I overlooked it.
 In patch 1, I tried to wait for the previous LR to finish but in order to do 
that correctly ( findbugs warning and other test failures with patch 1), the 
change was much bigger than what I anticipated.

I will try to fix it by the approach you suggested.



> TestContainerManager#testLocalingResourceWhileContainerRunning occasionally 
> times out
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-8672
>                 URL: https://issues.apache.org/jira/browse/YARN-8672
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.2.0
>            Reporter: Jason Lowe
>            Assignee: Chandni Singh
>            Priority: Major
>         Attachments: YARN-8672.001.patch, YARN-8672.002.patch
>
>
> Precommit builds have been failing in 
> TestContainerManager#testLocalingResourceWhileContainerRunning.  I have been 
> able to reproduce the problem without any patch applied if I run the test 
> enough times.  It looks like something is removing container tokens from the 
> nmPrivate area just as a new localizer starts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to