[ https://issues.apache.org/jira/browse/YARN-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676796#comment-16676796 ]
Wanqiang Ji commented on YARN-8977: ----------------------------------- [~kasha], [~cheersyang] Can you help to review this? thx~ This patch does not need new UT. > Remove explicit type when called AbstractYarnScheduler#getSchedulerNode to > avoid type casting > --------------------------------------------------------------------------------------------- > > Key: YARN-8977 > URL: https://issues.apache.org/jira/browse/YARN-8977 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Wanqiang Ji > Assignee: Wanqiang Ji > Priority: Major > Attachments: YARN-8977.001.patch > > > Due to the AbstractYarnScheduler#getSchedulerNode method return the generic > type, so I think don't need explicit type. > I found this issue in CapacityScheduler class. The warning message like: > {quote}Casting 'getSchedulerNode( nonKillableContainer.getAllocatedNode())' > to 'FiCaSchedulerNode' is redundant > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org