[
https://issues.apache.org/jira/browse/YARN-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677568#comment-16677568
]
Weiwei Yang commented on YARN-8977:
-----------------------------------
Hi [~jiwq]
Thanks for the patch, looks good. Two cents:
# Could u pls fix the 2 checkstyle issues?
# Could u also fix the redundant type cast in \{{TestContinuousScheduling}}
and \{{TestFairScheduler}}?
Thanks
> Remove explicit type when called AbstractYarnScheduler#getSchedulerNode to
> avoid type casting
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-8977
> URL: https://issues.apache.org/jira/browse/YARN-8977
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Attachments: YARN-8977.001.patch
>
>
> Due to the AbstractYarnScheduler#getSchedulerNode method return the generic
> type, so I think don't need explicit type.
> I found this issue in CapacityScheduler class. The warning message like:
> {quote}Casting 'getSchedulerNode( nonKillableContainer.getAllocatedNode())'
> to 'FiCaSchedulerNode' is redundant
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
