[
https://issues.apache.org/jira/browse/YARN-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786532#comment-13786532
]
Ravi Prakash commented on YARN-465:
-----------------------------------
Thanks for the updates Andrey! Here are some questions I had and comments.
- Why did you remove the proxy.join() from startup?
- If you removed proxy.join(), you didn't need to create a new method
(startServer). Just call main() on the class.
- In the test file in start(), did you mean to log the originalPort instead of
port? port would always be 0.
- Why did you have to create a core-default.xml file? Could you not have
hardcoded the port inside the test file? Also, could you please tell me where
hadoop.common.configuration.version is being used? I wasn't able to find it.
- Nit: Can you setName("proxy") -> setName("Proxy for test");
-Nit: Could you please put a more detailed message in
WebAppProxyForTest.start() when the proxy server starts up?
- In testWebAppProxyServlet(), what is the significance of
proxyConn.setRequestProperty("Cookie", "checked_application_0_0000=true"); ?
The test passes after commenting out that line too.
- What is testWebAppProxyServer that testWebAppProxyServlet()'s first test
isn't testing?
- What is testWebAppProxyServerMainMethod actually testing? counter is set 0 on
the very first successful try. Shouldn't that be the expected behavior. If we
are having to start the proxy server more than 1 time for the test to pass,
that is bad, and should make the test fail.
> fix coverage org.apache.hadoop.yarn.server.webproxy
> ----------------------------------------------------
>
> Key: YARN-465
> URL: https://issues.apache.org/jira/browse/YARN-465
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
> Reporter: Aleksey Gorshkov
> Assignee: Andrey Klochkov
> Attachments: YARN-465-branch-0.23-a.patch,
> YARN-465-branch-0.23.patch, YARN-465-branch-2-a.patch,
> YARN-465-branch-2--n3.patch, YARN-465-branch-2.patch, YARN-465-trunk-a.patch,
> YARN-465-trunk--n3.patch, YARN-465-trunk.patch
>
>
> fix coverage org.apache.hadoop.yarn.server.webproxy
> patch YARN-465-trunk.patch for trunk
> patch YARN-465-branch-2.patch for branch-2
> patch YARN-465-branch-0.23.patch for branch-0.23
> There is issue in branch-0.23 . Patch does not creating .keep file.
> For fix it need to run commands:
> mkdir
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy
> touch
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy/.keep
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
