[ 
https://issues.apache.org/jira/browse/YARN-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788542#comment-13788542
 ] 

Jason Lowe commented on YARN-465:
---------------------------------

+1 to the trunk patch, lgtm.

bq. Also, I made patches for branch-2 and trunk as similar as possible.

I diff'd the trunk and branch-2 patches and the only significant difference I 
could find was the branch-2 patch was importing 
org.apache.commons.lang.StringUtils while trunk imported 
org.apache.hadoop.util.StringUtils.  The trunk patch applies to branch-2 
cleanly and the unit tests pass, so is there any reason I'm missing to just 
apply the trunk patch to branch-2 as well?

> fix coverage  org.apache.hadoop.yarn.server.webproxy
> ----------------------------------------------------
>
>                 Key: YARN-465
>                 URL: https://issues.apache.org/jira/browse/YARN-465
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Aleksey Gorshkov
>            Assignee: Andrey Klochkov
>         Attachments: YARN-465-branch-0.23-a.patch, 
> YARN-465-branch-0.23.patch, YARN-465-branch-2-a.patch, 
> YARN-465-branch-2--n3.patch, YARN-465-branch-2--n4.patch, 
> YARN-465-branch-2--n5.patch, YARN-465-branch-2.patch, YARN-465-trunk-a.patch, 
> YARN-465-trunk--n3.patch, YARN-465-trunk--n4.patch, YARN-465-trunk--n5.patch, 
> YARN-465-trunk.patch
>
>
> fix coverage  org.apache.hadoop.yarn.server.webproxy
> patch YARN-465-trunk.patch for trunk
> patch YARN-465-branch-2.patch for branch-2
> patch YARN-465-branch-0.23.patch for branch-0.23
> There is issue in branch-0.23 . Patch does not creating .keep file.
> For fix it need to run commands:
> mkdir 
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy
> touch 
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy/.keep
>  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to