[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723003#comment-16723003
]
Szilard Nemeth commented on YARN-9133:
--------------------------------------
Thanks [~pbacsko] for your review comments!
1. No it's not a good idea, that's wy I marked the field with: "
//TODO this should be an simple non-static field, see: YARN-9121
". I simply had a separate Jira to fix that: YARN-9121
2. I don't want it to be a singleton, this is also the point of YARN-9121
3. fixed with the latest patch
> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>
> Key: YARN-9133
> URL: https://issues.apache.org/jira/browse/YARN-9133
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9133.001.patch, YARN-9133.001.patch,
> YARN-9133.002.patch
>
>
> Tests are not quite easy to read:
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also
> improve readability and clarity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
