[
https://issues.apache.org/jira/browse/YARN-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727775#comment-16727775
]
Weiwei Yang commented on YARN-9116:
-----------------------------------
Hi [~aihuaxu]
Thanks for the patch. I am +0 on adding this new property, as I previously
suggested. [~leftnoteasy], are you OK with adding this?
For the patch you uploaded, some comments
# CapacitySchedulerConfiguration: line 32: do not use wild char "*" in the
import
# Can we move {{createResourceFromString}}, {{parseResourcesString}},
\{{validateResourceTypes}} to \{{ResourceUtils}} class? Which is more
appropriate for the utility methods.
# Do we allow user to set more than memory/cpu in this property? E.g
\{{memory=1024,vcore=1,gpu=1}}. Follow the code in
\{{CapacitySchedulerConfiguration#getMaximumAllocationPerQueue}}, it only
accepts memory/cpu which seems would cause \{{validateResourceTypes}} to fail.
# If #3 is not supported, we need an appropriate check and a test case to
cover this scenario.
Thanks
> Capacity Scheduler: add the default maximum-allocation-mb and
> maximum-allocation-vcores for the queues
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-9116
> URL: https://issues.apache.org/jira/browse/YARN-9116
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Affects Versions: 2.7.0
> Reporter: Aihua Xu
> Assignee: Aihua Xu
> Priority: Major
> Attachments: YARN-9116.1.patch
>
>
> YARN-1582 adds the support of maximum-allocation-mb configuration per queue
> which is targeting to support larger container features on dedicated queues
> (larger maximum-allocation-mb/maximum-allocation-vcores for such queue) .
> While to achieve larger container configuration, we need to increase the
> global maximum-allocation-mb/maximum-allocation-vcores (e.g. 120G/256) and
> then override those configurations with desired values on the queues since
> queue configuration can't be larger than cluster configuration. There are
> many queues in the system and if we forget to configure such values when
> adding a new queue, then such queue gets default 120G/256 which typically is
> not what we want.
> We can come up with a queue-default configuration (set to normal queue
> configuration like 16G/8), so the leaf queues gets such values by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
