[
https://issues.apache.org/jira/browse/YARN-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734906#comment-16734906
]
Weiwei Yang edited comment on YARN-9173 at 1/5/19 2:01 PM:
-----------------------------------------------------------
Hi [~wilfreds]
Thanks for fixing this and adding more UTs. You are right, previous test was
too simple and doesn't have a good coverage.
The patch overall looks good to me, just one minor comment
Can you wrap up following code to a private method, e.g safeAdd, so it can be
reused,
{code:java}
try {
totalMaxShare = addExact(maxShare, totalMaxShare);
} catch (ArithmeticException ae) {
totalMaxShare = Long.MAX_VALUE;
break;
}
{code}
Thanks!
was (Author: cheersyang):
Hi [~wilfreds]
Thanks for fixing this and adding more UTs. You are right, previous test was
too simple and doesn't have a good coverage.
The patch overall looks good to me, just one minor comment
Can you wrap up following code to a private method, e.g safeAdd, so it can be
reused,
{code}
try {
totalMaxShare = addExact(maxShare, totalMaxShare);
} catch (ArithmeticException ae) {
totalMaxShare = Long.MAX_VALUE;
break;
}
{code}
Thanks!
> FairShare calculation broken for large values after YARN-8833
> -------------------------------------------------------------
>
> Key: YARN-9173
> URL: https://issues.apache.org/jira/browse/YARN-9173
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 3.3.0
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
> Attachments: YARN-9173.001.patch
>
>
> After the fix for the infinite loop in YARN-8833 we now get the wrong values
> back for fairshare calculations under certain circumstances. The current
> implementation works when the total resource is smaller than Integer.MAXVALUE.
> When the total resource goes above that value the number of iterations is not
> enough to converge to the correct value.
> The new test {{testResourceUsedWithWeightToResourceRatio()}} only checks that
> the calculation does not hang but does not check the outcome of the
> calculation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
