[ 
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750084#comment-16750084
 ] 

Peter Bacsko commented on YARN-9123:
------------------------------------

Two things:
1. Please use the {{assert}} methods a bit more consistently: either 
{{Assert.assert...()}} or static import them
2. If you have time, add error messages to the assertions

> Clean up and split testcases in TestNMWebServices for GPU support
> -----------------------------------------------------------------
>
>                 Key: YARN-9123
>                 URL: https://issues.apache.org/jira/browse/YARN-9123
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-9123.001.patch, YARN-9123.002.patch
>
>
> The following testcases can be cleaned up a bit: 
> TestNMWebServices#testGetNMResourceInfo - Can be split up to 3 different cases
> TestNMWebServices#testGetYarnGpuResourceInfo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to