[
https://issues.apache.org/jira/browse/YARN-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756890#comment-16756890
]
Bibin A Chundatt commented on YARN-9208:
----------------------------------------
[~Prabhu Joseph] Sorry for the delay.
Few comments
{code:java}
764 case "true": return LocalResourceVisibility.PUBLIC;
765 case "false": return LocalResourceVisibility.PRIVATE;
{code}
Better to give visibility type as argument (public,private,application) for
files
{code:java}
744 // Default Visibilty is set to APPLICATION type
745 int size = fileNames.size();
746 if (size == visibilities.size()) {
747 for (int i=0; i<size; i++) {
748 localizableFiles.add(Pair.of(new Path(fileNames.get(i)),
749 visibilities.get(i)));
750 }
751 } else {
752 for (int i=0; i<size; i++) {
753 localizableFiles.add(Pair.of(new Path(fileNames.get(i)),
754 LocalResourceVisibility.APPLICATION));
722 } 755 }
{code}
Thoughts on adding the visibility type to localized_files like "filename<some
separator>visibilityType,filename2<some separator>visibilityType" . Rename key
(localized_files) if required. Limitation of "size == visibilities.size()" we
could avoid.
{quote}The Client determines the visibilities (PRIVATE, PUBLIC and default
APPLICATION) based upon the permission of the input file. Also supports input
files from Hdfs.
{quote}
Does file scheme allow PUBLIC definition ??
> Distributed shell allow LocalResourceVisibility to be specified
> ---------------------------------------------------------------
>
> Key: YARN-9208
> URL: https://issues.apache.org/jira/browse/YARN-9208
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Bibin A Chundatt
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: YARN-9208-001.patch
>
>
> YARN-9008 add feature to add list of files to be localized.
> Would be great to have Visibility type too. Allows testing of PRIVATE and
> PUBLIC type too
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
