[ 
https://issues.apache.org/jira/browse/YARN-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757119#comment-16757119
 ] 

Prabhu Joseph commented on YARN-9208:
-------------------------------------

[~bibinchundatt] Attached new patch with suggested changes.

1. Used Enum valueOf instead of switch case.
2. Added visibility type to localized_files with format 
fileName1=visibilityType,fileName2=visibilityType,,
. Have used lastIndexOf to split fileName and visibilityType and so fileName 
can have =. 

bq. Does file scheme allow PUBLIC definition ??
File Scheme won't have Public type as the Hdfs staging directory 
(user.home/DistributedShell) is Private. The local file is copied to hdfs 
staging directory and then isPublic is checked to avoid IOException(File is not 
publicly accessible and as such cannot be part of the public cache) from 
FsDownload.
   

> Distributed shell allow LocalResourceVisibility to be specified
> ---------------------------------------------------------------
>
>                 Key: YARN-9208
>                 URL: https://issues.apache.org/jira/browse/YARN-9208
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bibin A Chundatt
>            Assignee: Prabhu Joseph
>            Priority: Minor
>         Attachments: YARN-9208-001.patch, YARN-9208-002.patch
>
>
> YARN-9008 add feature to add list of files to be localized.
> Would be great to have Visibility type too. Allows testing of PRIVATE and 
> PUBLIC type too



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to