[
https://issues.apache.org/jira/browse/YARN-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790737#comment-13790737
]
Karthik Kambatla commented on YARN-1068:
----------------------------------------
Thanks [~bikassaha] for the detailed review. Sorry for the delay in responding,
was caught up with some other issues. Uploaded a patch that addresses most of
the comments:
# Audit logging in RMHAProtocolService
# Update AdminService also to use RMServerUtils#verifyAccess
# YarnConfiguration overrides updateConnectAddr as well to complement
getSocketAddr
# Change argument names from nodeId to rmId
bq. cast not needed right?
Currently, RMHAServiceTarget constructor takes YarnConfiguration as an argument
and not Configuration. We can change this, but I think it is better to be
explicit in the kind of instance needed. Leaving the constructor as is requires
the cast.
bq. Should this be RMHAServiceProtocol address? Admins and ZKFC would be
connecting on this protocol right?
Updated the description to reflect that the RM listens at that address for both
rmhaadmin CLI and the failover controller (ZKFC). I think we should leave the
config name as ha.admin.address for the following reasons: (1) the user/admin
understand admin better than HAProtocolService as the latter requires them to
understand the protocol being used, (2) either CLI or ZKFC or actually
administrating the HA state of the RM, (3) we don't use protocol names anywhere
else in the configs.
> Add admin support for HA operations
> -----------------------------------
>
> Key: YARN-1068
> URL: https://issues.apache.org/jira/browse/YARN-1068
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.1.0-beta
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Labels: ha
> Attachments: yarn-1068-10.patch, yarn-1068-1.patch,
> yarn-1068-2.patch, yarn-1068-3.patch, yarn-1068-4.patch, yarn-1068-5.patch,
> yarn-1068-6.patch, yarn-1068-7.patch, yarn-1068-8.patch, yarn-1068-9.patch,
> yarn-1068-prelim.patch
>
>
> Support HA admin operations to facilitate transitioning the RM to Active and
> Standby states.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
