[
https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778716#comment-16778716
]
Daniel Templeton commented on YARN-9322:
----------------------------------------
Thanks, [~snemeth]. Comments:
# I think this patch will conflict with YARN-9318 on {{multiplyAndRoundUp()}}
# I like the cleanup of the ordering of the getters in {{FSQueueMetrics}}, but
{{getSteadyFairShareVCores()}} is out of place.
# As always, I'd appreciate meaningful assert messages.
# For completeness, you might consider adding an assert for a resource type not
in {{res}} in the new tests in {{TestFSQueueMetrics}}.
Overall, looks good. I don't care for the idea of having this big blob of
non-metrics in the metrics object, but I don't see a better way to do it at the
moment.
> Store metrics for custom resource types into FSQueueMetrics and query them in
> FairSchedulerQueueInfo
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-9322
> URL: https://issues.apache.org/jira/browse/YARN-9322
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: Screen Shot 2019-02-21 at 12.06.46.png,
> YARN-9322.001.patch, YARN-9322.002.patch, YARN-9322.003.patch
>
>
> YARN-8842 implemented storing and exposing of metrics of custom resources.
> FSQueueMetrics should have a similar implementation.
> All metrics stored in this class should have their custom resource
> counterpart.
> In a consequence of metrics were not stored for custom resource type,
> FairSchedulerQueueInfo haven't contained those values therefore the UI v1
> could not show them, obviously.
> See that gpu is missing from the value of "AM Max Resources" on the attached
> screenshot.
> Additionally, the callees of the following methods (in class
> FairSchedulerQueueInfo) should consider to query values for custom resource
> types too:
> getMaxAMShareMB
> getMaxAMShareVCores
> getAMResourceUsageMB
> getAMResourceUsageVCores
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
