[
https://issues.apache.org/jira/browse/YARN-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778685#comment-16778685
]
Daniel Templeton commented on YARN-9323:
----------------------------------------
Thanks, [~snemeth]. Comments:
# The patch doesn't compile: {noformat}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project hadoop-yarn-server-resourcemanager: Compilation failure: Compilation
failure:
[ERROR]
/Users/daniel/NetBeansProjects/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueueMetrics.java:[226,3]
cannot find symbol
[ERROR] symbol: class FSQueueMetricsForCustomResources
[ERROR] location: class
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSQueueMetrics
[ERROR]
/Users/daniel/NetBeansProjects/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueueMetrics.java:[227,12]
cannot find symbol
[ERROR] symbol: variable customResources
[ERROR] location: class
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSQueueMetrics
[ERROR]
/Users/daniel/NetBeansProjects/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java:[528,49]
incompatible types:
org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetricsForCustomResources.QueueMetricsCustomResource
cannot be converted to
org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueMetricsCustomResource{noformat}
# The {{QueueMetricsCustomResource}} is duplicated. It's there once as a
public class and once as an inner class of {{QueueMetricsForCustomResources}}.
# I don't understand why {{computeMaxAMResource()}} uses the fair share for CPU
and memory but custom resources come from the available resources in the root
queue. Shouldn't they all just come from the fair share, making all those
other changes unnecessary?
> FSLeafQueue#computeMaxAMResource does not override zero values for custom
> resources
> -----------------------------------------------------------------------------------
>
> Key: YARN-9323
> URL: https://issues.apache.org/jira/browse/YARN-9323
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9323.001.patch, YARN-9323.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
