[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781767#comment-16781767
]
Szilard Nemeth commented on YARN-9138:
--------------------------------------
Hi [~sunilg]!
Thanks for the comments!
1. Fixed.
2. msg is used both for logging and for the exception's constructor message
parameter, so I like the idea of keeping it as it is. What would you suggest
here?
3. Rename it to discoverer, as it's not really a "plugin".
4. I have a testcase that deals with the invalid XML scenario:
org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.TestGpuDiscoverer#testGetGpuDeviceInformationNvidiaSmiScriptWithInvalidXml
In this testcase, "<nvidia_smi_log></bla>" is generated as the XML. The test
verifies that in this case, YarnException is thrown with the correct message.
Did you have any other thing in mind for this point?
Thanks!
> Test error handling of nvidia-smi binary execution of GpuDiscoverer
> -------------------------------------------------------------------
>
> Key: YARN-9138
> URL: https://issues.apache.org/jira/browse/YARN-9138
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9138.001.patch, YARN-9138.002.patch,
> YARN-9138.003.patch, YARN-9138.004.patch, YARN-9138.005.patch
>
>
> The code that executes nvidia-smi (doing GPU device auto-discovery) don't
> have much test coverage.
> This patch adds tests to this part of the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
