[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782989#comment-16782989
]
Sunil Govindan commented on YARN-9138:
--------------------------------------
Thanks [~snemeth].
For messages, if its reused, you can definitely keep the variable which make
sense. However in cases where we pass an argument like this, we dont need a
final for this i think. {{final String msg =
getErrorMessageOfScriptExecution(e.getMessage());}}
Did you have any other thing in mind for this point?
Yes. I was thinking abt a partially constructed smi o/p. Are we covering this?
> Test error handling of nvidia-smi binary execution of GpuDiscoverer
> -------------------------------------------------------------------
>
> Key: YARN-9138
> URL: https://issues.apache.org/jira/browse/YARN-9138
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9138.001.patch, YARN-9138.002.patch,
> YARN-9138.003.patch, YARN-9138.004.patch, YARN-9138.005.patch,
> YARN-9138.006.patch
>
>
> The code that executes nvidia-smi (doing GPU device auto-discovery) don't
> have much test coverage.
> This patch adds tests to this part of the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
